Skip to content

add fgumi sort/zipper modules#11017

Draft
matthdsm wants to merge 2 commits intomasterfrom
module/fgumi
Draft

add fgumi sort/zipper modules#11017
matthdsm wants to merge 2 commits intomasterfrom
module/fgumi

Conversation

@matthdsm
Copy link
Copy Markdown
Contributor

@matthdsm matthdsm commented Mar 23, 2026

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@matthdsm matthdsm requested a review from nh13 March 23, 2026 13:46
@matthdsm matthdsm mentioned this pull request Mar 23, 2026
Closed
6 tasks
@matthdsm
Copy link
Copy Markdown
Contributor Author

matthdsm commented Mar 23, 2026

Awaiting fix for fulcrumgenomics/fgumi#181 before proceeding here

@matthdsm matthdsm self-assigned this Mar 23, 2026
@matthdsm matthdsm marked this pull request as draft March 23, 2026 14:19
@SPPearce
Copy link
Copy Markdown
Contributor

SPPearce commented Apr 22, 2026

Looks like the issue is fixed now, if you want to continue @matthdsm

@nh13
Copy link
Copy Markdown
Member

nh13 commented Apr 22, 2026 •
edited
Loading

I'll be doing an fgumi release in the next few days, if not sooner. I'd vote for waiting, and then I can update this PR with any changes based on that release, which will be very well tested. If so, let me know if you'd be ok with me touching this PR, or if you'd like a stacked PR.

@matthdsm
Copy link
Copy Markdown
Contributor Author

matthdsm commented Apr 22, 2026

I have no problem with you touching this PR 😄 If anything, this one was to kick off development for fgumi and stimulate others to pick up the other subcommands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nh13 nh13 Awaiting requested review from nh13

At least 1 approving review is required to merge this pull request.

Assignees

@matthdsm matthdsm

Labels

size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthdsm @SPPearce @nh13